Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for iwantmyname #1588

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Add DNS provider for iwantmyname #1588

merged 2 commits into from
Feb 12, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 12, 2022

  • have a homogeneous design with the other providers
  • pass the linter
  • do go mod tidy
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
rm -rf .lego/

IWANTMYNAME_USERNAME=xxx IWANTMYNAME_PASSWORD=yyy ./lego -m [email protected] --dns iwantmyname -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

@dorianim could you test by running the previous command (you have to use a real domain and email)?

Closes #1587

@dorianim
Copy link

Thank you! I'll try it out :D

@dorianim
Copy link

Looks like it worked fine 👍

2022/02/12 11:21:08 No key found for account [email protected]. Generating a P256 key.
2022/02/12 11:21:08 Saved key to /home/dorian/Documents/git/clones/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2022/02/12 11:21:12 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf
Do you accept the TOS? Y/n
y
2022/02/12 11:21:18 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/home/dorian/Documents/git/clones/lego/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2022/02/12 11:21:18 [INFO] [*.dorian.im, dorian.im] acme: Obtaining bundled SAN certificate
2022/02/12 11:21:20 [INFO] [*.dorian.im] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/1661973478
2022/02/12 11:21:20 [INFO] [dorian.im] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/1661973488
2022/02/12 11:21:20 [INFO] [*.dorian.im] acme: use dns-01 solver
2022/02/12 11:21:20 [INFO] [dorian.im] acme: Could not find solver for: tls-alpn-01
2022/02/12 11:21:20 [INFO] [dorian.im] acme: Could not find solver for: http-01
2022/02/12 11:21:20 [INFO] [dorian.im] acme: use dns-01 solver
2022/02/12 11:21:20 [INFO] [*.dorian.im] acme: Preparing to solve DNS-01
2022/02/12 11:21:26 [INFO] [dorian.im] acme: Preparing to solve DNS-01
2022/02/12 11:21:27 [INFO] [*.dorian.im] acme: Trying to solve DNS-01
2022/02/12 11:21:27 [INFO] [*.dorian.im] acme: Checking DNS record propagation using [10.10.0.1:53 127.0.0.53:53]
2022/02/12 11:21:29 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2022/02/12 11:21:37 [INFO] [*.dorian.im] The server validated our request
2022/02/12 11:21:37 [INFO] [dorian.im] acme: Trying to solve DNS-01
2022/02/12 11:21:37 [INFO] [dorian.im] acme: Checking DNS record propagation using [10.10.0.1:53 127.0.0.53:53]
2022/02/12 11:21:39 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2022/02/12 11:22:04 [INFO] [dorian.im] acme: Waiting for DNS record propagation.
2022/02/12 11:22:08 [INFO] [dorian.im] The server validated our request
2022/02/12 11:22:08 [INFO] [*.dorian.im] acme: Cleaning DNS-01 challenge
2022/02/12 11:22:09 [INFO] [dorian.im] acme: Cleaning DNS-01 challenge
2022/02/12 11:22:10 [INFO] [*.dorian.im, dorian.im] acme: Validations succeeded; requesting certificates
2022/02/12 11:22:11 [INFO] [*.dorian.im] Server responded with a certificate.

@ldez ldez removed the state/need-user-tests Need users to test functionality label Feb 12, 2022
@ldez ldez requested a review from dmke February 12, 2022 11:02
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldez ldez added this to the v4.7 milestone Feb 12, 2022
@ldez ldez merged commit 4b2f870 into go-acme:master Feb 12, 2022
@ldez ldez deleted the feat/iwantmyname branch February 12, 2022 11:33
@dorianim
Copy link

Thanks for the quick implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: iwantmyname.com
3 participants