Fall back to pkgconfig for resolving libtiff #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also https://github.com/gnustep/tools-windows-msvc/blob/master/phases/43-libtiff.bat#L34-L36 - another workaround for the same problem. |
fredkiefer
reviewed
Sep 14, 2024
In certain configurations (e.g. when built in debug mode using the msvc compiler), the libtiff link library may have a 'd' suffix -- 'tiffd'. `AC_CHECK_LIB(tiff, TIFFReadScanline)` will fail because it doesn't search for `tiffd`. Rather than hardcoding the `tiffd` variant, use pkg-config to find libtiff.
qmfrederik
force-pushed
the
configure-tiff
branch
from
45edc31
to
336b77b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain configurations (e.g. when built in debug mode using the msvc compiler), the libtiff link library may have a 'd' suffix -- 'tiffd.lib' instead of
tiff.lib. This is an explicit choice in the libtiff build process: https://gitlab.com/libtiff/libtiff/-/blob/master/cmake/WindowsSupport.cmake#L28In this case,
AC_CHECK_LIB(tiff, TIFFReadScanline)will fail because it doesn't search fortiffd.Rather than hardcoding the
tiffdvariant, use pkg-config to find libtiff.