kernel: Fix typo in implementation name #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AVX2 kernels in `volk_16ic_x2_dot_prod_16ic` were named incorrectly. Instead of `_avx2` the function names ended with `_axv2`. This commit fixes the typo. However, this does change two function names in files that we install. This might require us to add a wrapper with the old name that just calls the new, and correct, name.
|
Thinking since this was caught so quickly that we just need to get it fixed in the code here since it will never have been "in the wild" to need further changes ... not 100% sure of course ... |
|
I'm going ahead with the merge on the hopes that this will take care of any issues with those typos ... if not then we'll deal with it in another PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AVX2 kernels in
volk_16ic_x2_dot_prod_16icwere named incorrectly.Instead of
_avx2the function names ended with_axv2. This commitfixes the typo.
However, this does change two function names in files that we install.
This might require us to add a wrapper with the old name that just calls
the new, and correct, name.