Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable typecheck #89

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat: Disable typecheck #89

merged 3 commits into from
Oct 10, 2024

Conversation

notJoon
Copy link
Contributor

@notJoon notJoon commented Oct 10, 2024

Description

  • Disabled typecheck lint by apply golnagci config file.
    • This lint was outputting lint results unrelated to gno. Additionally, the amount of inspection decreased, resulting in improved lint performance.
  • Remove SymbolTable from engine
  • ignore body-less functions when check cycles
  • field alignment

@notJoon notJoon added bug bug A-lint Adding or updating lint T-engine Type: related with engine (or internal) labels Oct 10, 2024
@notJoon notJoon marked this pull request as ready for review October 10, 2024 07:13
@notJoon notJoon merged commit 0db3a94 into main Oct 10, 2024
5 checks passed
@notJoon notJoon deleted the disable-typecheck branch October 10, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lint Adding or updating lint bug bug T-engine Type: related with engine (or internal)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notJoon