Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix c.matches integrity check #218

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

jfschwarz
Copy link
Collaborator

It was overly restrictive in not supporting children with ParameterType.Bytes to follow ParameterType.AbiEncoded. It now shares the logic with checkConditionIntegrity.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-roles-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 9:38am
zodiac-roles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 9:38am

Copy link

github-actions bot commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7395600142

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.719%

Totals Coverage Status
Change from base Build 7212169530: 0.0%
Covered Lines: 665
Relevant Lines: 666

💛 - Coveralls

@jfschwarz jfschwarz merged commit 6ed86af into main Jan 5, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@jfschwarz jfschwarz deleted the fix-matches-integrity-check branch January 5, 2024 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant