-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/save user session venv (solves #879) #880
base: master
Are you sure you want to change the base?
WIP: Feature/save user session venv (solves #879) #880
Conversation
Hi terminator developers, I just need to figure out, how to get the virtual environment of a current terminal.
cannot work in this case, as we would need to run a python program within the current shell. Do you know, if this information is kept somewhere in the shell / process ? (it should, since command prompts also show the current venv) |
Can you fix the conflicts from your version change? Then I think I can merge this in. This is getting really close to adding functionality that is not strictly part of the terminal emulator process, but I think I'll allow it. To really add venv functionality, you could look at adding venv to the layout editor as well. Add it as an extra parameter to the layouts. I'm worried that this is getting into "Python IDE" territory, but I'm allowing it as this is what a lot of people are actually using it for. |
Hi @mattrose, I can fully understand your concerns There is one "game-stopper" preventing me from finallising the pull request (next to my time limitations): |
Additionally to the current working directory, it would be nice to also store the python virtual environment that is currently used in the config file and re-activate it on Session restore.
This solves #879