fix: correctly reference ABCIErrorKey (#84)

gnolang · Sep 22, 2023 · 194034b · 194034b
1 parent 579b69d
commit 194034b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/src/provider/jsonrpc/jsonrpc.test.ts b/src/provider/jsonrpc/jsonrpc.test.ts
@@ -1,5 +1,6 @@
 import {
   ABCIAccount,
+  ABCIErrorKey,
   ABCIResponse,
   BlockInfo,
   BlockResult,
@@ -83,7 +84,7 @@ describe('JSON-RPC Provider', () => {
     const mockLog = 'random error message';
     const invalidResult: BroadcastTxSyncResult = {
       error: {
-        ABCIErrorKey: mockError,
+        [ABCIErrorKey]: mockError,
       },
       data: null,
       Log: mockLog,

diff --git a/src/provider/jsonrpc/jsonrpc.ts b/src/provider/jsonrpc/jsonrpc.ts
@@ -1,5 +1,6 @@
 import { Provider } from '../provider';
 import {
+  ABCIErrorKey,
   ABCIResponse,
   BlockInfo,
   BlockResult,
@@ -175,7 +176,7 @@ export class JSONRPCProvider implements Provider {
     // Check if there is an immediate tx-broadcast error
     // (originating from basic transaction checks like CheckTx)
     if (response.error) {
-      const errType: string = response.error.ABCIErrorKey;
+      const errType: string = response.error[ABCIErrorKey];
       const log: string = response.Log;
 
       throw constructRequestError(errType, log);
@@ -196,15 +197,15 @@ export class JSONRPCProvider implements Provider {
 
     // Check if there is an immediate tx-broadcast error (in CheckTx)
     if (check_tx.ResponseBase.Error) {
-      const errType: string = check_tx.ResponseBase.Error.ABCIErrorKey;
+      const errType: string = check_tx.ResponseBase.Error[ABCIErrorKey];
       const log: string = check_tx.ResponseBase.Log;
 
       throw constructRequestError(errType, log);
     }
 
     // Check if there is a parsing error with the transaction (in DeliverTx)
     if (deliver_tx.ResponseBase.Error) {
-      const errType: string = deliver_tx.ResponseBase.Error.ABCIErrorKey;
+      const errType: string = deliver_tx.ResponseBase.Error[ABCIErrorKey];
       const log: string = deliver_tx.ResponseBase.Log;
 
       throw constructRequestError(errType, log);

diff --git a/src/provider/websocket/ws.test.ts b/src/provider/websocket/ws.test.ts
@@ -1,5 +1,6 @@
 import {
   ABCIAccount,
+  ABCIErrorKey,
   ABCIResponse,
   ABCIResponseBase,
   BeginBlock,
@@ -264,7 +265,7 @@ describe('WS Provider', () => {
     const mockLog = 'random error message';
     const invalidResult: BroadcastTxSyncResult = {
       error: {
-        ABCIErrorKey: mockError,
+        [ABCIErrorKey]: mockError,
       },
       data: null,
       Log: mockLog,

diff --git a/src/provider/websocket/ws.ts b/src/provider/websocket/ws.ts
@@ -1,5 +1,6 @@
 import { Provider } from '../provider';
 import {
+  ABCIErrorKey,
   ABCIResponse,
   BlockInfo,
   BlockResult,
@@ -287,7 +288,7 @@ export class WSProvider implements Provider {
     // Check if there is an immediate tx-broadcast error
     // (originating from basic transaction checks like CheckTx)
     if (broadcastResponse.error) {
-      const errType: string = broadcastResponse.error.ABCIErrorKey;
+      const errType: string = broadcastResponse.error[ABCIErrorKey];
       const log: string = broadcastResponse.Log;
 
       throw constructRequestError(errType, log);
@@ -309,15 +310,15 @@ export class WSProvider implements Provider {
 
     // Check if there is an immediate tx-broadcast error (in CheckTx)
     if (check_tx.ResponseBase.Error) {
-      const errType: string = check_tx.ResponseBase.Error.ABCIErrorKey;
+      const errType: string = check_tx.ResponseBase.Error[ABCIErrorKey];
       const log: string = check_tx.ResponseBase.Log;
 
       throw constructRequestError(errType, log);
     }
 
     // Check if there is a parsing error with the transaction (in DeliverTx)
     if (deliver_tx.ResponseBase.Error) {
-      const errType: string = deliver_tx.ResponseBase.Error.ABCIErrorKey;
+      const errType: string = deliver_tx.ResponseBase.Error[ABCIErrorKey];
       const log: string = deliver_tx.ResponseBase.Log;
 
       throw constructRequestError(errType, log);