Chore: Add HasByName, etc. Update go.mod replace for berty/gno #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
HasByName
and other fixes. It has three commits:HasByName
,HasByAddress
andHasByNameOrAddress
. It also has the bug fix forGetByAddress
to return the errorErrKeyNotFound
same asGetByName
. Therefore, we updateGetByAddress
in api.go to check for this and returnrpc.ErrCode_ErrCryptoKeyNotFound
.GetByAddress
takes a crypto.Address. However in PR chore: Add API GetKeyInfoByName. In CreateAccount doc, say to use it to check #64, we used a bech32 string address forGetKeyInfoByAddress
. But it should take a byte array address, just like the Keybase method and likequeryAccount
. This is the same byte array address in the response toGetByKeyInfoByName
, etc. (Currently the UI doesn't useGetKeyInfoByAddress
so this change shouldn't affect the front end.)HasByName
,HasByAddress
andHasByNameOrAddress
.