Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add HasByName, etc. Update go.mod replace for berty/gno #66

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Oct 30, 2023

This pull request adds HasByName and other fixes. It has three commits:

  1. Use the latest go.mod replace berty/gno v0.0.6 . This includes HasByName, HasByAddress and HasByNameOrAddress. It also has the bug fix for GetByAddress to return the error ErrKeyNotFound same as GetByName. Therefore, we update GetByAddress in api.go to check for this and return rpc.ErrCode_ErrCryptoKeyNotFound.
  2. The Keybase method GetByAddress takes a crypto.Address. However in PR chore: Add API GetKeyInfoByName. In CreateAccount doc, say to use it to check #64, we used a bech32 string address for GetKeyInfoByAddress. But it should take a byte array address, just like the Keybase method and like queryAccount. This is the same byte array address in the response to GetByKeyInfoByName, etc. (Currently the UI doesn't use GetKeyInfoByAddress so this change shouldn't affect the front end.)
  3. Finally, add support for HasByName, HasByAddress and HasByNameOrAddress.

@jefft0 jefft0 requested a review from D4ryl00 October 30, 2023 13:58
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 1755bcc into gnolang:main Oct 30, 2023
@jefft0 jefft0 deleted the chore/add-HasByName-etc branch October 30, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants