Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display chain information in key listing #36

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Display chain information in key listing #36

merged 2 commits into from
Dec 19, 2024

Conversation

iuricmp
Copy link
Collaborator

@iuricmp iuricmp commented Dec 17, 2024

Enhance the key listing feature by displaying associated chain information for each key.

@iuricmp iuricmp requested a review from jefft0 December 17, 2024 16:55
jefft0
jefft0 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@jefft0 jefft0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android an iOS simulators by creating an account for Berty-dev, then using the gnokey CLI to add coins on testnet5. Gnokey Mobile correctly shows the new account being on both Berty-dev and testnet5.

@iuricmp iuricmp merged commit 29ba2f4 into gnolang:main Dec 19, 2024
1 check passed
@iuricmp iuricmp deleted the check-for-registry branch December 19, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefft0 jefft0 jefft0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuricmp @jefft0