feat(cli): add listen flag #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Apr 11, 2023
| fs.StringVar( | ||
| &c.rpcListenAddr, | ||
| "rpc.laddr", | ||
| "tcp://127.0.0.1:26657", |
There was a problem hiding this comment.
This string is used 3 times in this file, and should be a constant. This constant should probably be located in a pkg, and not in the main.
moul
reviewed
Apr 11, 2023
Comment on lines
+127
to
+129
| if c.rpcListenAddr != "tcp://127.0.0.1:26657" { | ||
| cfg.RPC.ListenAddress = c.rpcListenAddr | ||
| } |
There was a problem hiding this comment.
This is not the way to manage this. Instead, you should parse flags directly against the unmarshalled config file.
|
Shall we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a
-listenflag to be able to listen on0.0.0.0inside a docker container