Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #670 (bcrypt cost) to fix #680 #684

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

grepsuzette
Copy link
Contributor

@grepsuzette grepsuzette commented Apr 1, 2023

This reverts e0c50ec (#670), fixing #680.
It breaks decoding of existing accounts.
For instance if you addpkg, it gives:

Enter password.
ciphertext decryption failed

Changing bcryptSecurityParameter = 12 (from 11) makes it work again.

Better change until we find a better solution.

This reverts e0c50ec (gnolang#670)
It breaks decoding of existing accounts.
For instance if you addpkg, it gives:

Enter password.
ciphertext decryption failed

Changing bcryptSecurityParameter = 12 (from 11) makes it work again.

Better change until we find a better solution.
@grepsuzette grepsuzette requested a review from a team as a code owner April 1, 2023 02:25
@peter7891
Copy link
Contributor

This reverts e0c50ec (#670), fixing #680. It breaks decoding of existing accounts. For instance if you addpkg, it gives:

Enter password. ciphertext decryption failed

Changing bcryptSecurityParameter = 12 (from 11) makes it work again.

Better change until we find a better solution.

Breaking changes are okay, at this point.
I've talked to @jaekwon . We just need to document it.

@grepsuzette
Copy link
Contributor Author

Breaking changes are okay, at this point. I've talked to @jaekwon . We just need to document it.

If we delete the website, it's a breaking change too, but that does not imply we should do it.

Hey it's nothing personal. But the proposed course of action was to first revert the breaking change, and then discuss. People that git pull must the master must be able to continue their work, and if there's amendment to bcrypt it better not to be rushed.

We should consider the testnet as rehearsal for what's to come with the production, or else we're never going to be ready.

@moul moul merged commit 2b7642b into gnolang:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants