Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP workshop #639

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

WIP workshop #639

wants to merge 15 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Mar 23, 2023

Imported manfred (moul)'s tictactoe and fixed the tests.


These are internal notes not related to the workshop.

  • TODO create another issue to see why defer m.injectLocOnPanic() doesn't work (see XXX).
  • TODO related to above, make clearer error message when trying to pass a Gno struct with unexposed fields to fmt.Sprintf etc, so user knows to avoid t.Errorf("", x) but replace with t.Errorf("", x.String()) etc.
  • TODO related to the above, maybe make t.Errorf() not use fmt.

@jaekwon jaekwon requested a review from a team as a code owner March 23, 2023 19:49
@moul moul marked this pull request as draft May 4, 2023 16:22
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: 🌟 Wanted for Launch
Development

Successfully merging this pull request may close these issues.

3 participants