Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change references of go1.18 to go1.19 #600

Merged
merged 1 commit into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The gno repository is primarily based on Golang (Go), and Gnolang (Gno).

The primary tech stack for working on the repository:

- Go (version 1.18+)
- Go (version 1.19+)
- make (for using Makefile configurations)
- Docker (for using the official Docker setup files)

Expand Down Expand Up @@ -147,7 +147,7 @@ If you wish to test a `.gno` Realm or Package, you can utilize the `gnodev` tool
`gnodev test <path-to-dir> --verbose`


To learn more about how `gnodev` can help you when developing gno code, you can look into the available
To learn more about how `gnodev` can help you when developing gno code, you can look into the available
subcommands by running:

`gnodev --help`
Expand Down Expand Up @@ -234,7 +234,7 @@ You can utilize the detailed PR template by appending the following query param

Found something funky while using gno? You can report it to the team using GitHub issues.

Before opening an issue, please check for existing open and closed Issues to see if that bug/feature has already been
Before opening an issue, please check for existing open and closed Issues to see if that bug/feature has already been
reported/requested. If you find a relevant topic, you can comment on that issue.

In the issue, please provide as much information as possible, for example:
Expand Down Expand Up @@ -272,7 +272,7 @@ Commit standard, and be short and precise.
A general rule of thumb:

- Use Conventional Commits for PR titles
- Never favor rewriting history in PRs (rebases have very few exceptions, like implementation rewrites;
- Never favor rewriting history in PRs (rebases have very few exceptions, like implementation rewrites;
see [A Word on Rebasing](#a-word-on-rebasing))
- Tend to make separate commits for logically separate changes

Expand Down
2 changes: 1 addition & 1 deletion cmd/gnodev/test.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func execTest(cfg *testCfg, args []string, io *commands.IO) error {

// go.mod
modPath := filepath.Join(tempdirRoot, "go.mod")
err = makeTestGoMod(modPath, gno.ImportPrefix, "1.18")
err = makeTestGoMod(modPath, gno.ImportPrefix, "1.19")
if err != nil {
return fmt.Errorf("write .mod file: %w", err)
}
Expand Down