feat(website): add dark theme #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
approved these changes
Feb 15, 2023
harry-hov
reviewed
Feb 15, 2023
| } | ||
|
|
||
| blockquote blockquote { | ||
| margin: 0; | ||
| background-color: #aaa2; | ||
| background-color: var(--quote-2-background, #aaa4); |
There was a problem hiding this comment.
I'm just curious about the reason behind this change (i.e #aaa2 -> #aaa4)
Rest LGTM 💯
There was a problem hiding this comment.
Ah - that's an oversight. I had changed it to #aaa considering the 2 at the end was a typo, but I added it back later after realising it wasn't. Should be alright though - the opacity should only have changed by a 0.125 :)
moul
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for prefers-color-scheme: dark (ie. color scheme in browser settings) on the gnoland website. Just a personal itch I wanted to scratch :)
Screenshots from Firefox 109 on Linux: