Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): correct OwnerID retrieval #3401

Closed
wants to merge 5 commits into from

Conversation

ltzmaxwell
Copy link
Contributor

When an object is persisted, the owner field is not saved along with it. As a result, when the object is restored, it does not have an associated owner, even though the OwnerID field is available.

This discrepancy can lead to side effects, such as failing to correctly retrieve the owner. Consequently, operations like markDirtyAncestors do not function as expected.

This PR addresses the issue by updating the GetOwnerID function to correctly handle this scenario.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 23, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 23, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ltzmaxwell
Copy link
Contributor Author

maybe not necessary, or unknown/wider side effects. make it draft.

@ltzmaxwell ltzmaxwell marked this pull request as draft December 25, 2024 07:53
@ltzmaxwell ltzmaxwell closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

2 participants