-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Genesis commit Nicolas's homePage #3372
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Hey! Marking this as draft as I assume you're still working on it. |
I think it's good, you can merge it now |
hey @Nicolas76000, I see that your home realm is a simple title. Since this is not really a demo of anything useful, I suggest you publish this package to the chain permissionlessly with gnokey or playground + adena. If you wish your code to be added to the monorepo, there needs to be some additional demonstration value to it. |
I understand but this is only one of the stages of our collaboration
Le jeu. 19 déc. 2024, 15:26, Leon Hudak ***@***.***> a écrit :
… hey @Nicolas76000 <https://github.com/Nicolas76000>, I see that your home
realm is a simple title. Since this is not really a demo of anything
useful, I suggest you publish this package to the chain permissionlessly
with gnokey or playground + adena.
If you wish your code to be added to the monorepo, there needs to be some
additional demonstration value to it.
—
Reply to this email directly, view it on GitHub
<#3372 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3VVBTTOXHITUFRAO5Z75B32GLJQTAVCNFSM6AAAAABT46E4BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJUGI4DQMZXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's perfectly fine, however, this PR by itself is not really a contribution worthwhile in the monorepo. As I said, please either add more to this PR to make it unique and an example, or simply deploy this code permissionlessly. |
feat: Hello friends here is my humble first contribution