Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Genesis commit Nicolas's homePage #3372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nicolas76000
Copy link

@Nicolas76000 Nicolas76000 commented Dec 19, 2024

feat: Hello friends here is my humble first contribution

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 19, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: Nicolas76000/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@leohhhn
Copy link
Contributor

leohhhn commented Dec 19, 2024

Hey! Marking this as draft as I assume you're still working on it.

@leohhhn leohhhn marked this pull request as draft December 19, 2024 13:13
@leohhhn leohhhn self-requested a review December 19, 2024 13:13
@Nicolas76000 Nicolas76000 changed the title Genesis commit Nicolas's homePage feat: Genesis commit Nicolas's homePage Dec 19, 2024
@Nicolas76000 Nicolas76000 marked this pull request as ready for review December 19, 2024 13:15
@Nicolas76000
Copy link
Author

Hey! Marking this as draft as I assume you're still working on it.

I think it's good, you can merge it now
Thanks @leohhhn

@leohhhn
Copy link
Contributor

leohhhn commented Dec 19, 2024

hey @Nicolas76000, I see that your home realm is a simple title. Since this is not really a demo of anything useful, I suggest you publish this package to the chain permissionlessly with gnokey or playground + adena.

If you wish your code to be added to the monorepo, there needs to be some additional demonstration value to it.

@Nicolas76000
Copy link
Author

Nicolas76000 commented Dec 19, 2024 via email

@leohhhn
Copy link
Contributor

leohhhn commented Dec 19, 2024

That's perfectly fine, however, this PR by itself is not really a contribution worthwhile in the monorepo. As I said, please either add more to this PR to make it unique and an example, or simply deploy this code permissionlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

4 participants