-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint): fix 'make install' failure due to bad 'BeginTransaction' c… #3369
Conversation
…all in lint.io lint.go: add missing 'gasMeter' param to 'BeginTransaction' call Impact: caused 'make install' to fail on branch 'master' with the following error: cmd/gno/lint.go:147:34: not enough arguments in call to ts.BeginTransaction have ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store) want ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter) make[1]: *** [install] Error 1
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, btw this bug breaks the teritori-dapp CI
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Addresses #3368
…all in lint.io
lint.go: add missing 'gasMeter' param to 'BeginTransaction' call
Impact: caused 'make install' to fail on branch 'master' with the following error:
Testing: This fix resolves test failure commanded by
make test
: