Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): fix 'make install' failure due to bad 'BeginTransaction' c… #3369

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dmanpearl
Copy link
Contributor

@dmanpearl dmanpearl commented Dec 19, 2024

Addresses #3368

…all in lint.io

lint.go: add missing 'gasMeter' param to 'BeginTransaction' call

Impact: caused 'make install' to fail on branch 'master' with the following error:

cmd/gno/lint.go:147:34: not enough arguments in call to ts.BeginTransaction
    have ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
          "github.com/gnolang/gno/tm2/pkg/store/types".Store)
    want ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
          "github.com/gnolang/gno/tm2/pkg/store/types".Store,
          "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter)
make[1]: *** [install] Error 1

Testing: This fix resolves test failure commanded by make test:

FAIL	github.com/gnolang/gno/gnovm/cmd/gno [build failed]

…all in lint.io

lint.go: add missing 'gasMeter' param to 'BeginTransaction' call

    Impact: caused 'make install' to fail on branch 'master' with the
    following error:

        cmd/gno/lint.go:147:34: not enough arguments in call to ts.BeginTransaction
            have ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
                  "github.com/gnolang/gno/tm2/pkg/store/types".Store)
            want ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
                  "github.com/gnolang/gno/tm2/pkg/store/types".Store,
                  "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter)
        make[1]: *** [install] Error 1
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 19, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @moul)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: dmanpearl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 19, 2024
Copy link
Contributor

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw this bug breaks the teritori-dapp CI

@n0izn0iz n0izn0iz removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl thehowl merged commit c8cd8f4 into gnolang:master Dec 19, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

6 participants