-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Ivan's registry, home realm #3354
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
When creating a PR, create it as Draft first 🙏 |
Also you say finalizing, but your home realm package is empty 👀 |
return ErrInvalidAddr | ||
} | ||
|
||
if err := checkAuthorized; err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if err := checkAuthorized; err != nil { | |
if err := checkAuthorized(); err != nil { |
return nil | ||
} | ||
|
||
func assertAuthorized() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused.
mainAddress std.Address | ||
backupAddress std.Address | ||
|
||
ErrInvalidAddr = errors.New("leon's config: invalid address") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErrInvalidAddr = errors.New("leon's config: invalid address") | |
ErrInvalidAddr = errors.New("ursulovic's config: invalid address") |
…es such as updating home page data
I was few commits behind before pushing
Thank you @moul, I have implemented all your suggestions!
Sorry, I forgot to stage the files earlier :/. I’ve added them now. I have created the Realm package, which primarily displays random blockchain "wisdom" and provides some information about me. Tomorrow, I plan to implement functionality of modifying the realm data if authorization is passed using my registry realm. |
Created registry for further development of realms, finalising home realm.