Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Ivan's registry, home realm #3354

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Ursulovic
Copy link

Created registry for further development of realms, finalising home realm.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 17, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 17, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: Ursulovic/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@leohhhn
Copy link
Contributor

leohhhn commented Dec 17, 2024

When creating a PR, create it as Draft first 🙏

@leohhhn leohhhn marked this pull request as draft December 17, 2024 16:01
@leohhhn leohhhn changed the title Created registry, home real in progress feat(): Ivan's registry, home realm Dec 17, 2024
@leohhhn leohhhn changed the title feat(): Ivan's registry, home realm feat(examples): Ivan's registry, home realm Dec 17, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Dec 17, 2024

Also you say finalizing, but your home realm package is empty 👀

return ErrInvalidAddr
}

if err := checkAuthorized; err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err := checkAuthorized; err != nil {
if err := checkAuthorized(); err != nil {

return nil
}

func assertAuthorized() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused.

mainAddress std.Address
backupAddress std.Address

ErrInvalidAddr = errors.New("leon's config: invalid address")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ErrInvalidAddr = errors.New("leon's config: invalid address")
ErrInvalidAddr = errors.New("ursulovic's config: invalid address")

Ivan Ursulovic added 2 commits December 18, 2024 03:34
@Ursulovic
Copy link
Author

Thank you @moul, I have implemented all your suggestions!

Also you say finalizing, but your home realm package is empty 👀

Sorry, I forgot to stage the files earlier :/. I’ve added them now. I have created the Realm package, which primarily displays random blockchain "wisdom" and provides some information about me. Tomorrow, I plan to implement functionality of modifying the realm data if authorization is passed using my registry realm.

@thehowl thehowl requested a review from leohhhn December 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

4 participants