-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(memdb): use tidwall/btree in place of map #3327
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 The pull request head branch must be up-to-date with its base (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
obviously this created problems elsewhere, but i still don't know where |
The goal was to improve execution time of tests, and other users of MemDB like gnodev. Ballpark performance improvement should be around 2x. Flamegraph now has most of the time in tests spent in consensus-land:
Previously, most of the time was spent allocating strings to sort the keys, to then be passed to the MemIterator. We get free key sorting with b-trees.