Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memdb): use tidwall/btree in place of map #3327

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Dec 11, 2024

The goal was to improve execution time of tests, and other users of MemDB like gnodev. Ballpark performance improvement should be around 2x. Flamegraph now has most of the time in tests spent in consensus-land:

image

Previously, most of the time was spent allocating strings to sort the keys, to then be passed to the MemIterator. We get free key sorting with b-trees.

@thehowl thehowl self-assigned this Dec 11, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Dec 11, 2024
@thehowl thehowl requested a review from gfanton December 11, 2024 16:44
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 11, 2024

🛠 PR Checks Summary

🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (thehowl:dev/morgan/mem-db-btree) is up to date with base (master): behind by 2 / ahead by 5

Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 73.56322% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/db/memdb/mem_db.go 73.56% 20 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@thehowl thehowl changed the title feat(memdb): use tidwall/btree implementation for btree feat(memdb): use tidwall/btree in place of map Dec 11, 2024
@thehowl
Copy link
Member Author

thehowl commented Dec 11, 2024

obviously this created problems elsewhere, but i still don't know where

@thehowl thehowl marked this pull request as draft December 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants