Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scope the CI and add QoL improvements #3316

Merged
merged 16 commits into from
Dec 19, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR modifies the monorepo workflows, and introduces QoL improvements to the overall CI.
The PR is not meant to be a cover-all fix for the CI, but a start on how we can begin improving it.

@gfanton We should start looking into how to group txtars soon 🙏

@zivkovicmilos zivkovicmilos self-assigned this Dec 10, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 10, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 10, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @zivkovicmilos)
  • Determine if infra needs to be updated before merging
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
Determine if infra needs to be updated before merging

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: master
    └── 🟢 Or
        ├── 🔴 A changed file matches this pattern: Dockerfile
        ├── 🔴 A changed file matches this pattern: ^misc/deployments
        ├── 🔴 A changed file matches this pattern: ^misc/docker-
        ├── 🟢 A changed file matches this pattern: ^.github/workflows/releaser.*\.yml$ (filename: .github/workflows/releaser-master.yml)
        └── 🟢 A changed file matches this pattern: ^.github/workflows/portal-loop\.yml$ (filename: .github/workflows/portal-loop.yml)

Can be checked by

  • team devops

@zivkovicmilos zivkovicmilos requested a review from n2p5 December 10, 2024 14:56
.github/golangci.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. The most important ones are keeping go version in less config files as possible and keep dependabot tags as they were, because they will be easier to maintain (everything needed to create a new workflow is in only one config file, you don't need to change dependabot config)

.github/codecov.yml Outdated Show resolved Hide resolved
.github/codecov.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark-master-push.yml Outdated Show resolved Hide resolved
.github/workflows/contribs.yml Outdated Show resolved Hide resolved
.github/workflows/main_template.yml Outdated Show resolved Hide resolved
.github/workflows/releaser.yml Outdated Show resolved Hide resolved
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 11, 2024
.github/codecov.yml Outdated Show resolved Hide resolved
.github/codecov.yml Outdated Show resolved Hide resolved
@zivkovicmilos
Copy link
Member Author

Skipping @Gno2D2 check since @sw360cab is OOO, and there are no infra changes needed with this PR

@zivkovicmilos zivkovicmilos merged commit e506a8d into master Dec 19, 2024
28 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/ci-qol branch December 19, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Development

Successfully merging this pull request may close these issues.

5 participants