Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump golangci lint to 1.62 #3278

Merged
merged 9 commits into from
Dec 6, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Dec 5, 2024

fix #3066

Bump golangci-lint to 1.62, this bump include the following change.

  • Removing gopls from direct dependency as it creates some conflict with the latest version of golangci-lint. gopls is not meant to be tracked as a direct dependency tool; it's a personal tool and it's dependent on the user's Go version, not the project-specific version.
  • Update all printf-like methods that should not use non-constant format input. Instead, I choose to duplicate those methods into two separate methods: one should be dedicated to formatting, and the other one to simple direct messaging. ex. errors.Wrap -> errors.Wrapf
  • Ignoring gosec issue with ripemd160 for now, I will open an issue to double-check this one. ✅ Double-checked with @zivkovicmilos & @jaekwon, we can ignore it.
  • Ignoring gosec G115 Integer overflow conversion; there is no solution to check the overflow in the time of conversion, so I think the linter shouldn't check for the overflow.
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@gfanton gfanton self-assigned this Dec 5, 2024
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 5, 2024
@gfanton gfanton requested a review from zivkovicmilos December 5, 2024 16:08
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 5, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request
🟢 The pull request head branch must be up-to-date with its base

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (gfanton:fix/bump-golangci-lint) is up to date with base (master): behind by 0 / ahead by 9

@gfanton gfanton force-pushed the fix/bump-golangci-lint branch from 3718a3a to 7a1f6d8 Compare December 5, 2024 16:13
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 5, 2024
@gfanton gfanton force-pushed the fix/bump-golangci-lint branch from 235a0f3 to cc52b62 Compare December 5, 2024 18:39
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 6, 2024
misc/devdeps/deps.go Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

Super happy for this 🎉 🎉 🎉

gnovm/pkg/gnolang/store.go Outdated Show resolved Hide resolved
@thehowl thehowl merged commit 08fb49a into gnolang:master Dec 6, 2024
105 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Dec 7, 2024
fix gnolang#3066

Bump `golangci-lint` to `1.62`, this bump include the following change.
- Removing `gopls` from direct dependency as it creates some conflict
with the latest version of `golangci-lint`. `gopls` is not meant to be
tracked as a direct dependency tool; it's a personal tool and it's
dependent on the user's Go version, not the project-specific version.
- Update all `printf`-like methods that should not use non-constant
format input. Instead, I choose to duplicate those methods into two
separate methods: one should be dedicated to formatting, and the other
one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf`
- ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue
to double-check this one.~ ✅ Double-checked with @zivkovicmilos &
@jaekwon, we can ignore it.
- Ignoring `gosec` G115 Integer overflow conversion; there is no
solution to check the overflow in the time of conversion, so I think the
linter shouldn't check for the overflow.


<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Signed-off-by: gfanton <[email protected]>
Co-authored-by: Morgan <[email protected]>
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Dec 9, 2024
fix gnolang#3066

Bump `golangci-lint` to `1.62`, this bump include the following change.
- Removing `gopls` from direct dependency as it creates some conflict
with the latest version of `golangci-lint`. `gopls` is not meant to be
tracked as a direct dependency tool; it's a personal tool and it's
dependent on the user's Go version, not the project-specific version.
- Update all `printf`-like methods that should not use non-constant
format input. Instead, I choose to duplicate those methods into two
separate methods: one should be dedicated to formatting, and the other
one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf`
- ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue
to double-check this one.~ ✅ Double-checked with @zivkovicmilos &
@jaekwon, we can ignore it.
- Ignoring `gosec` G115 Integer overflow conversion; there is no
solution to check the overflow in the time of conversion, so I think the
linter shouldn't check for the overflow.


<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Signed-off-by: gfanton <[email protected]>
Co-authored-by: Morgan <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
fix gnolang#3066

Bump `golangci-lint` to `1.62`, this bump include the following change.
- Removing `gopls` from direct dependency as it creates some conflict
with the latest version of `golangci-lint`. `gopls` is not meant to be
tracked as a direct dependency tool; it's a personal tool and it's
dependent on the user's Go version, not the project-specific version.
- Update all `printf`-like methods that should not use non-constant
format input. Instead, I choose to duplicate those methods into two
separate methods: one should be dedicated to formatting, and the other
one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf`
- ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue
to double-check this one.~ ✅ Double-checked with @zivkovicmilos &
@jaekwon, we can ignore it.
- Ignoring `gosec` G115 Integer overflow conversion; there is no
solution to check the overflow in the time of conversion, so I think the
linter shouldn't check for the overflow.


<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

---------

Signed-off-by: gfanton <[email protected]>
Co-authored-by: Morgan <[email protected]>
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

Bump golangci-lint to a version that supports go 1.23
5 participants