-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump golangci lint to 1.62 #3278
Conversation
I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process. The following requirements must be fulfilled before a pull request can be merged. These requirements are defined in this configuration file. Automated Checks🟢 Maintainers must be able to edit this pull request Manual ChecksNo manual checks match this pull request. Debug
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
3718a3a
to
7a1f6d8
Compare
Signed-off-by: gfanton <[email protected]>
…tifier Signed-off-by: gfanton <[email protected]>
235a0f3
to
cc52b62
Compare
Super happy for this 🎉 🎉 🎉 |
fix gnolang#3066 Bump `golangci-lint` to `1.62`, this bump include the following change. - Removing `gopls` from direct dependency as it creates some conflict with the latest version of `golangci-lint`. `gopls` is not meant to be tracked as a direct dependency tool; it's a personal tool and it's dependent on the user's Go version, not the project-specific version. - Update all `printf`-like methods that should not use non-constant format input. Instead, I choose to duplicate those methods into two separate methods: one should be dedicated to formatting, and the other one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf` - ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue to double-check this one.~ ✅ Double-checked with @zivkovicmilos & @jaekwon, we can ignore it. - Ignoring `gosec` G115 Integer overflow conversion; there is no solution to check the overflow in the time of conversion, so I think the linter shouldn't check for the overflow. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Signed-off-by: gfanton <[email protected]> Co-authored-by: Morgan <[email protected]>
fix gnolang#3066 Bump `golangci-lint` to `1.62`, this bump include the following change. - Removing `gopls` from direct dependency as it creates some conflict with the latest version of `golangci-lint`. `gopls` is not meant to be tracked as a direct dependency tool; it's a personal tool and it's dependent on the user's Go version, not the project-specific version. - Update all `printf`-like methods that should not use non-constant format input. Instead, I choose to duplicate those methods into two separate methods: one should be dedicated to formatting, and the other one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf` - ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue to double-check this one.~ ✅ Double-checked with @zivkovicmilos & @jaekwon, we can ignore it. - Ignoring `gosec` G115 Integer overflow conversion; there is no solution to check the overflow in the time of conversion, so I think the linter shouldn't check for the overflow. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Signed-off-by: gfanton <[email protected]> Co-authored-by: Morgan <[email protected]>
fix gnolang#3066 Bump `golangci-lint` to `1.62`, this bump include the following change. - Removing `gopls` from direct dependency as it creates some conflict with the latest version of `golangci-lint`. `gopls` is not meant to be tracked as a direct dependency tool; it's a personal tool and it's dependent on the user's Go version, not the project-specific version. - Update all `printf`-like methods that should not use non-constant format input. Instead, I choose to duplicate those methods into two separate methods: one should be dedicated to formatting, and the other one to simple direct messaging. ex. `errors.Wrap` -> `errors.Wrapf` - ~Ignoring `gosec` issue with `ripemd160` for now, I will open an issue to double-check this one.~ ✅ Double-checked with @zivkovicmilos & @jaekwon, we can ignore it. - Ignoring `gosec` G115 Integer overflow conversion; there is no solution to check the overflow in the time of conversion, so I think the linter shouldn't check for the overflow. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details> --------- Signed-off-by: gfanton <[email protected]> Co-authored-by: Morgan <[email protected]>
fix #3066
Bump
golangci-lint
to1.62
, this bump include the following change.gopls
from direct dependency as it creates some conflict with the latest version ofgolangci-lint
.gopls
is not meant to be tracked as a direct dependency tool; it's a personal tool and it's dependent on the user's Go version, not the project-specific version.printf
-like methods that should not use non-constant format input. Instead, I choose to duplicate those methods into two separate methods: one should be dedicated to formatting, and the other one to simple direct messaging. ex.errors.Wrap
->errors.Wrapf
Ignoring✅ Double-checked with @zivkovicmilos & @jaekwon, we can ignore it.gosec
issue withripemd160
for now, I will open an issue to double-check this one.gosec
G115 Integer overflow conversion; there is no solution to check the overflow in the time of conversion, so I think the linter shouldn't check for the overflow.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description