Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update test3 mentions, add test5 mentions #3259

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Dec 3, 2024

Description

This PR updates the mentions of test3 after its deprecation, and adds text on test5.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@leohhhn leohhhn requested a review from Kouteki December 3, 2024 10:47
@leohhhn leohhhn marked this pull request as ready for review December 3, 2024 10:48
@Gno2D2 Gno2D2 requested review from a team December 3, 2024 10:48
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 3, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request
🟢 The pull request head branch must be up-to-date with its base
🟢 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (leohhhn:test3-docs) is up to date with base (master): behind by 0 / ahead by 4

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/concepts/testnets.md)

Then

🟢 Requirement satisfied
└── 🟢 Or
    ├── 🟢 And
    │   ├── 🟢 Pull request author is a member of the team: devrels
    │   └── 🟢 At least 1 user(s) of the team tech-staff approved pull request
    └── 🔴 And
        ├── 🔴 Pull request author is a member of the team: tech-staff
        └── 🔴 At least 1 user(s) of the team devrels approved pull request

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn leohhhn mentioned this pull request Dec 3, 2024
2 tasks
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 3, 2024
Copy link
Contributor

@Kouteki Kouteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/concepts/testnets.md Show resolved Hide resolved
@notJoon notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 4, 2024
@Gno2D2 Gno2D2 requested a review from a team December 4, 2024 09:39
@notJoon
Copy link
Member

notJoon commented Dec 4, 2024

Aproved by core members. so remove review/triage-pending flag

@leohhhn leohhhn merged commit c1b928f into gnolang:master Dec 4, 2024
60 checks passed
@leohhhn leohhhn deleted the test3-docs branch December 4, 2024 15:59
omarsy pushed a commit to TERITORI/gno that referenced this pull request Dec 7, 2024
## Description

This PR updates the mentions of test3 after its deprecation, and adds
text on test5.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
## Description

This PR updates the mentions of test3 after its deprecation, and adds
text on test5.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

6 participants