Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: const conversions for 32 bits #3186

Merged
merged 1 commit into from
Nov 24, 2024
Merged

fix: const conversions for 32 bits #3186

merged 1 commit into from
Nov 24, 2024

Conversation

petar-dambovaliev
Copy link
Contributor

The const conversion pr broke 32bit platform build because the comparison wasn't portable for that platform. This is a fix.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 24, 2024
@petar-dambovaliev petar-dambovaliev changed the title fix const conversions for 32 bits fix: const conversions for 32 bits Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/values_conversions.go 16.66% 3 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@zivkovicmilos zivkovicmilos merged commit c6f8dd4 into master Nov 24, 2024
101 of 103 checks passed
@zivkovicmilos zivkovicmilos deleted the 32bitconv branch November 24, 2024 02:34
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
The const conversion pr broke 32bit platform build because the
comparison wasn't portable for that platform. This is a fix.
albttx pushed a commit that referenced this pull request Jan 10, 2025
The const conversion pr broke 32bit platform build because the
comparison wasn't portable for that platform. This is a fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

2 participants