chore: remove ancient docker integration in misc
#3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
sw360cab
approved these changes
Nov 25, 2024
|
It makes sense to have an integration test that differs from txtar's "simulation" of binaries. Instead, we should conduct a real test using independent containers and establishing actual TCP connections with another process. Can we create an equivalent solution that is not only functional but also more maintainable than the initial one I developed? |
n0izn0iz
pushed a commit
to n0izn0iz/gno
that referenced
this pull request
Nov 26, 2024
## Description This PR removes the ancient docker integration test contained in `misc` that fails, and a random docker compose, also in `misc`. This test package is actually never even run on `master`, because it requires a specific build flag `docker` 🤷♂️ Closes gnolang#3161 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
6 tasks
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
## Description This PR removes the ancient docker integration test contained in `misc` that fails, and a random docker compose, also in `misc`. This test package is actually never even run on `master`, because it requires a specific build flag `docker` 🤷♂️ Closes gnolang#3161 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the ancient docker integration test contained in
miscthat fails, and a random docker compose, also inmisc.This test package is actually never even run on
master, because it requires a specific build flagdocker🤷♂️Closes #3161
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description