Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add embedded stdlibs #3165

Closed
wants to merge 8 commits into from
Closed

feat: add embedded stdlibs #3165

wants to merge 8 commits into from

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Nov 20, 2024 •
edited
Loading

Embeds stdlibs sources in the stdlibs package.
Also adds a test to ensure we embed exactly what we want.

First step to address #2730 (comment)

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 20, 2024
@n0izn0iz
chore: add doc
f4138d8 
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz
chore: rename stuff
df80f36 
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz n0izn0iz marked this pull request as ready for review November 20, 2024 11:38
@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 20, 2024
@n0izn0iz n0izn0iz mentioned this pull request Nov 20, 2024
Draft
15 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/stdlibs/embedded.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki added this to the 🚀 Mainnet launch milestone Nov 22, 2024
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 22, 2024
@Kouteki Kouteki requested a review from thehowl November 22, 2024 05:57
@n0izn0iz
Copy link
Contributor Author

rewrote in #3168

@n0izn0iz n0izn0iz closed this Nov 26, 2024
@n0izn0iz n0izn0iz deleted the embed-stdlibs branch November 26, 2024 04:45
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 29, 2024
@gnolang gnolang deleted a comment from Gno2D2 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl Awaiting requested review from thehowl

Assignees

@n0izn0iz n0izn0iz

Labels
📦 🤖 gnovm Issues or PRs gnovm related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
🚀 Mainnet beta launch
Development

Successfully merging this pull request may close these issues.
3 participants
@n0izn0iz @notJoon @Kouteki