refactor: remove useless code and fix a test #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
+ Coverage 63.79% 63.80% +0.01%
==========================================
Files 549 549
Lines 78833 78824 -9
==========================================
+ Hits 50288 50297 +9
+ Misses 25153 25138 -15
+ Partials 3392 3389 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
aeddi
changed the title
aeddi
force-pushed
the
dev/aeddi/bft-fixes
branch
from
3f907eb to
c34bfd5
Compare
aeddi
changed the title
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
- Commit gnolang@4b6219c move `ValidateBlock` method from `blockExec` to `state` since `blockExec.db` was an unused parameter. (simplify + remove misleading comment) - Commit gnolang@4f02bcd just removes useless `Sprintf` found in this package - Commit gnolang@c34bfd5 improves `ValidateBasic` method (adding one more validation test that was marked with a `TODO` comment) - Commit gnolang@df75b32 removes useless case testing the size of a fixed-sized array, see: https://github.com/gnolang/gno/blob/b3800b7dfb864396ac74dc20390e728bc0b2d88e/tm2/pkg/crypto/crypto.go#L24-L30 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateBlockmethod fromblockExectostatesinceblockExec.dbwas an unused parameter. (simplify + remove misleading comment)Sprintffound in this packageValidateBasicmethod (adding one more validation test that was marked with aTODOcomment)gno/tm2/pkg/crypto/crypto.go
Lines 24 to 30 in b3800b7
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description