-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gnohealth cli tool #3158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
moul
reviewed
Nov 19, 2024
moul
approved these changes
Nov 19, 2024
aeddi
force-pushed
the
dev/aeddi/gnohealth
branch
from
November 20, 2024 00:46
816a322
to
9eff680
Compare
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
This PR adds a tool to the contribs dedicated to adding subcommands for health checks. The first available subcommand simply detects timestamp drift on a given chain. This test was useful in the context of this issue: gnolang#1950. However, it could later run on a dedicated server or on a GitHub Actions cron job to alert us in case significant drift occurs again. Results on test5 : ``` > gnohealth timestamp -ws -remote 'wss://rpc.test5.gno.land:443/websocket' -verbose block 411344 drifted of 3.094940942s (max 10s): OK block 411345 drifted of 2.368750176s (max 10s): OK block 411346 drifted of 2.310184977s (max 10s): OK block 411347 drifted of 2.158713327s (max 10s): OK block 411348 drifted of 2.203484957s (max 10s): OK block 411349 drifted of 2.156479203s (max 10s): OK block 411350 drifted of 2.155613458s (max 10s): OK block 411351 drifted of 2.296832155s (max 10s): OK block 411352 drifted of 2.132230389s (max 10s): OK block 411353 drifted of 2.181071735s (max 10s): OK block 411354 drifted of 2.575055701s (max 10s): OK block 411355 drifted of 2.034728695s (max 10s): OK block 411356 drifted of 2.285932658s (max 10s): OK block 411357 drifted of 2.330991247s (max 10s): OK block 411358 drifted of 2.365136593s (max 10s): OK block 411359 drifted of 2.035198868s (max 10s): OK block 411360 drifted of 2.128274141s (max 10s): OK block 411361 drifted of 2.48608003s (max 10s): OK block 411362 drifted of 2.072144703s (max 10s): OK block 411363 drifted of 2.297280076s (max 10s): OK block 411364 drifted of 2.224310386s (max 10s): OK no timestamp drifted beyond the maximum delta (average 2.280639734s) ``` Results on test4 : ``` > gnohealth timestamp -ws -remote 'wss://rpc.test4.gno.land:443/websocket' -verbose block 3618022 drifted of 3.765561468s (max 10s): OK block 3618023 drifted of 3.697091353s (max 10s): OK block 3618024 drifted of 3.576602477s (max 10s): OK block 3618025 drifted of 3.542585771s (max 10s): OK block 3618026 drifted of 3.72231133s (max 10s): OK block 3618027 drifted of 3.751154575s (max 10s): OK block 3618028 drifted of 8.312827308s (max 10s): OK block 3618029 drifted of 3.712806121s (max 10s): OK block 3618030 drifted of 3.65324572s (max 10s): OK no timestamp drifted beyond the maximum delta (average 4.192687347s) ``` <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to the contribs dedicated to adding subcommands for health checks. The first available subcommand simply detects timestamp drift on a given chain.
This test was useful in the context of this issue: #1950.
However, it could later run on a dedicated server or on a GitHub Actions cron job to alert us in case significant drift occurs again.
Results on test5 :
Results on test4 :
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description