-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): mirror realm #3156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3156 +/- ##
==========================================
- Coverage 63.81% 63.78% -0.04%
==========================================
Files 549 549
Lines 78833 78833
==========================================
- Hits 50308 50282 -26
- Misses 25136 25158 +22
- Partials 3389 3393 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
this can reflect recursively like two mirrors infinitely, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever :)
Yep, but since you cannot pass in an argument to the Idea was @jeronimoalbi's, all credits to him |
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description Adds the mirror realm. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests </details>
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description Adds the mirror realm. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests </details>
Description
Adds the mirror realm.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description