Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add hello_world, update r/demo/event #3130

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Nov 15, 2024

Description

We don't have a clean & simple hello_world realm. I also updated the doc on the r/demo/events realm, and also renamed it to emit.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (a1a7cb3) to head (f5b179e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
- Coverage   63.79%   63.79%   -0.01%     
==========================================
  Files         549      549              
  Lines       78819    78819              
==========================================
- Hits        50281    50279       -2     
- Misses      25146    25150       +4     
+ Partials     3392     3390       -2     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.70% <ø> (ø)
gnovm 67.93% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.38% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn requested a review from moul November 15, 2024 05:00
@leohhhn leohhhn changed the title feat(examples): add hello_world, update r/demo/event doc feat(examples): add hello_world, update r/demo/event Nov 15, 2024
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 15, 2024
@Kouteki Kouteki removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 17, 2024
@leohhhn leohhhn merged commit 6a13619 into gnolang:master Nov 18, 2024
134 checks passed
@leohhhn leohhhn deleted the hello branch November 18, 2024 02:40
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

We don't have a clean & simple hello_world realm. I also updated the doc
on the `r/demo/events` realm, and also renamed it to emit.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
albttx pushed a commit that referenced this pull request Jan 10, 2025
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

We don't have a clean & simple hello_world realm. I also updated the doc
on the `r/demo/events` realm, and also renamed it to emit.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants