fix(gnovm): save object when refCount changed

[omarsy]

This PR a fix in the gnovm to ensure that objects are saved correctly when their reference count changes.

closes: #2266 #1543

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[jefft0]

Hello @omarsy . There is a merge conflict with master in gno.land/pkg/sdk/vm/gas_test.go . Can you resolve it?

[jefft0]

The main change is to one file gnovm/pkg/gnolang/realm.go . The rest of the changes are tests. All CI checks pass.

[jefft0]

Removed the review/triage-pending label because jefft0 approved. Ready for core devs to review if the change is technically correct.

[ltzmaxwell]

just start looking.

[Gno2D2]

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: TERITORI/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[zivkovicmilos]

@omarsy
Can you please check the CI? 🙏

[omarsy]

@omarsy Can you please check the CI? 🙏

Done ^^

[ltzmaxwell]

LGTM, thank you!

[ltzmaxwell]

nit: not used. and is this same with zrealm14?

[omarsy]

Nice catch ^^ . Don't know why I have this test. Maybe I used it for my local test

[thehowl]

what's going on here?

[omarsy]

It is caused by the change of the reference count of the time package.
It occurs because the time.Time struct is a field of the Board object. When the Board object is referenced, it indirectly causes the reference count of the time package to change, as the time.Time struct is part of the Board

[thehowl]

mhhh, should package values be persisted like this? I don't think so?

In the very least, we shouldn't have a 15k line long file with the entire PackageValue of the time package, but I'm thinking whether we need to add an exception to saving package values?

[omarsy]

Maybe we should avoid to log Block operation like this 7438f8a#diff-152fa445ed649a7f12eb067c6a67f7c6cb98c3242e23da200744b851aaeb3b20R522 ?