feat(examples): finalize acl package #2987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtekgrinder
requested review from
sw360cab and
petar-dambovaliev
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
This was referenced Oct 20, 2024
notJoon
added
the
review/triage-pending
notJoon
suggested changes
Oct 21, 2024
omarsy
reviewed
Oct 27, 2024
| // TODO: helpers to adds multiple permissions at once -> {verbs: []string{"read","write"}}. | ||
| // TODO: helpers to delete users from gorups. | ||
| // TODO: helpers to quickly reset states. | ||
| func (d *Directory) RemoveUserFromGroup(user std.Address, group string) { |
There was a problem hiding this comment.
Should we return an error or a boolean indicating success when removing a field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing functionalities from the acl package:
Everything can be tested by running
gno test examples/gno.land/p/demo/aclContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description