-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): grc20 refactor #2983
Conversation
Signed-off-by: moul <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
=======================================
Coverage 63.76% 63.76%
=======================================
Files 548 548
Lines 78681 78681
=======================================
+ Hits 50171 50172 +1
- Misses 25128 25129 +1
+ Partials 3382 3380 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
cc @MikaelVallenet @n0izn0iz, any thoughts? |
looks good to me, i like the teller pattern & add metadata in token level instead of ledger/bank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still mostly naming considerations.
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
This reverts commit 007a2ac.
…into dev/moul/grc20-refacto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall implementation and naming LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR should also update the docs
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
@leohhhn do you want to update the doc in this PR or in your big refactor? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I feel like showcases and more examples will come after we merge this PR.
I'll also port my constant product dex example afterwards.
As for the doc, I can push changes to your branch here to update it, or make a PR when we merge this. Let me know how you want to go about it.
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
This PR extracts the grc20 refactor from gnolang#2551, which is a meta PR containing several contract improvements and additions that depend on new Gnovm features that haven't been merged yet. Please review this grc20 refactor with a focus on its API. Several valuable comments can be found in gnolang#2551. Additionally, you can discover new contracts using grc20 in gnolang#2551, such as `minidex`, `atomicswap`, `grc20reg`, `test20`, and `vault`. Addresses gnolang#1832 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Morgan <[email protected]> Co-authored-by: Morgan Bazalgette <[email protected]> Co-authored-by: Leon Hudak <[email protected]>
This PR extracts the grc20 refactor from #2551, which is a meta PR containing several contract improvements and additions that depend on new Gnovm features that haven't been merged yet.
Please review this grc20 refactor with a focus on its API. Several valuable comments can be found in #2551. Additionally, you can discover new contracts using grc20 in #2551, such as
minidex
,atomicswap
,grc20reg
,test20
, andvault
.Addresses #1832