feat(tm2): add sdk/params module #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
requested review from
a team,
jaekwon,
piux2 and
zivkovicmilos
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 63.18% 63.02% -0.17%
==========================================
Files 561 565 +4
Lines 78636 81124 +2488
==========================================
+ Hits 49690 51125 +1435
- Misses 25569 26545 +976
- Partials 3377 3454 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
moul
force-pushed
the
dev/moul/mod-params
branch
2 times, most recently
from
e31c026 to
c177c69
Compare
github-actions
bot
added
📦 🤖 gnovm
moul
force-pushed
the
dev/moul/mod-params
branch
4 times, most recently
from
df1da8c to
2a5b678
Compare
moul
force-pushed
the
dev/moul/mod-params
branch
2 times, most recently
from
4c04221 to
95ab0bd
Compare
Signed-off-by: moul <[email protected]>
moul
force-pushed
the
dev/moul/mod-params
branch
from
95ab0bd to
783a044
Compare
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
thehowl
pushed a commit
that referenced
this pull request
Oct 22, 2024
The change does not appear to be applied to my PR #2920, so I am opening a dedicated PR to make Codecov aware. Signed-off-by: moul <[email protected]>
Could you elaborate on why this decision ? Edit(@moul): udpated the OC |
thehowl
reviewed
Oct 22, 2024
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
4 tasks
jaekwon
approved these changes
Oct 22, 2024
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
zivkovicmilos
pushed a commit
that referenced
this pull request
Nov 12, 2024
- [x] add `r/sys/params` - [x] add `genesis/genesis_params.toml` - [x] port some existing configurations - [x] open issue: add LRU lazy caching with instant invalidation using a transient store (#3023) Depends on #2920 Depends on #3003 (cherry-picked) Blocking #2911 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Morgan <[email protected]>
r3v4s
pushed a commit
to gnoswap-labs/gno
that referenced
this pull request
Dec 10, 2024
- [x] add `r/sys/params` - [x] add `genesis/genesis_params.toml` - [x] port some existing configurations - [x] open issue: add LRU lazy caching with instant invalidation using a transient store (gnolang#3023) Depends on gnolang#2920 Depends on gnolang#3003 (cherry-picked) Blocking gnolang#2911 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnoland783a044std.GetConfigfrom the contract part? -> No, it allows unsafe, complex, and implicit patterns. If you want to get a value from another contract, you can either import it or use a registry pattern. This approach preserves type safety and other GNOVM protections.SetConfig(onlyr/sys), or maybe set an expensive gas price?interface{}from the setters and use specific types, including in the tm2 implementation (string, uint64, int64, bool, bytes).<type>suffix addition, but ensure that the type is explicitly defined by the user; and remove the table.Related #1418
Related #1856