Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verifySignature function #2776

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Villaquiranm
Copy link
Contributor

@Villaquiranm Villaquiranm commented Sep 9, 2024

related to #2777

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.09%. Comparing base (05cd4f5) to head (43e14eb).

Files with missing lines Patch % Lines
gnovm/stdlibs/std/native.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
- Coverage   63.10%   63.09%   -0.01%     
==========================================
  Files         564      564              
  Lines       79273    79311      +38     
==========================================
+ Hits        50023    50041      +18     
- Misses      25886    25906      +20     
  Partials     3364     3364              
Flag Coverage Δ
contribs/gnodev 60.62% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (-0.95%) ⬇️
gno.land 67.56% <ø> (ø)
gnovm 67.26% <89.47%> (+0.02%) ⬆️
misc/genstd 79.72% <ø> (ø)
misc/logos 19.45% <ø> (-0.51%) ⬇️
tm2 62.25% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Villaquiranm Villaquiranm force-pushed the feat/verifySignature branch 3 times, most recently from 76ec144 to 74ed842 Compare September 11, 2024 06:56
@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@notJoon
Copy link
Member

notJoon commented Oct 10, 2024

CI failed. could you please check and fix this?

@Villaquiranm
Copy link
Contributor Author

Villaquiranm commented Oct 11, 2024

CI failed. could you please check and fix this?

I think it is ok just one does not want to finish do not know why
@notJoon

Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it purely through test runs, it executed well without any significant issues.

Although I also looked into related issues, it might be better to conduct a more detailed review in the next stage.

remove: review/triage-pending

@notJoon notJoon removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 18, 2024
@thehowl
Copy link
Member

thehowl commented Oct 23, 2024

I'm still not convinced by this approach. I think we should have verification happen at the protol level rather than happen at the Gno level. Can we not use the message signers as I pointed out in the discussion on #2777?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants