-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verifySignature function #2776
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2776 +/- ##
==========================================
- Coverage 63.10% 63.09% -0.01%
==========================================
Files 564 564
Lines 79273 79311 +38
==========================================
+ Hits 50023 50041 +18
- Misses 25886 25906 +20
Partials 3364 3364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
76ec144
to
74ed842
Compare
74ed842
to
707ba33
Compare
CI failed. could you please check and fix this? |
I think it is ok just one does not want to finish do not know why |
98a6ec0
to
43e14eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it purely through test runs, it executed well without any significant issues.
Although I also looked into related issues, it might be better to conduct a more detailed review in the next stage.
remove: review/triage-pending
I'm still not convinced by this approach. I think we should have verification happen at the protol level rather than happen at the Gno level. Can we not use the message signers as I pointed out in the discussion on #2777? |
related to #2777
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description