Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove slash from test4 endpoint #2603

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 18, 2024

The trailing slash at the end of the test4 endpoint seems redundant. I suggest removing it for consistency

https://github.com/gnolang/gno/blob/master/docs/reference/network-config.md?plain=1#L1-L19

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested a review from moul as a code owner July 18, 2024 14:47
@leohhhn
Copy link
Contributor

leohhhn commented Jul 18, 2024

Thanks. When you make PRs, even if they are this small, please add a small description to the PR. Also, please make sure to check the contributor checklist boxes.

@leohhhn leohhhn merged commit 92e51c2 into gnolang:master Jul 18, 2024
9 of 10 checks passed
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
The trailing slash at the end of the test4 endpoint seems redundant. I
suggest removing it for consistency


https://github.com/gnolang/gno/blob/master/docs/reference/network-config.md?plain=1#L1-L19

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants