fix: govDAO: Use GetOrigCaller() to be able to run proposals using MsgRun #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
requested review from
deelawn and
thehowl
and removed request for
a team
ajnavarro
requested review from
zivkovicmilos
and removed request for
a team,
deelawn and
thehowl
thehowl
previously requested changes
Jul 9, 2024
There was a problem hiding this comment.
using getorigcaller here means that a malicious contract in the middle can perform actions on the DAO on behalf of the OrigCaller
we are, in fact, considering removing GetOrigCaller entirely
if the issue we're trying to tackle is using MsgRun with a closure, we should fix that one instead
ajnavarro
force-pushed
the
dev/ajnavarro/feature/govDAO-hotfix
branch
from
3b412e4 to
cf28bc5
Compare
Fixed that and also improve details rendering adding an extra space. Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
dev/ajnavarro/feature/govDAO-hotfix
branch
from
cf28bc5 to
9d0a13c
Compare
ajnavarro
changed the title
|
Going back to using GetOrigCaller(). Added a warning to change when MsgRun can persist the code that is going out of the main function scope. |
ajnavarro
changed the title
Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
changed the title
zivkovicmilos
approved these changes
Jul 9, 2024
zivkovicmilos
dismissed
thehowl’s stale review
We discussed internally, and the change is alright as a patch. Dismissing so we can merge quickly 🙏
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…gRun (gnolang#2556) Fixed that and also improve details rendering adding an extra space. --------- Signed-off-by: Antonio Navarro Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that and also improve details rendering adding an extra space.