Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix broken link in tm2/pkg/amino/README.md #2322

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

grepsuzette
Copy link
Contributor

@grepsuzette grepsuzette commented Jun 11, 2024

This is a broken link:

## Amino in the Wild
* Amino:binary spec in [Tendermint](
https://github.com/tendermint/tendermint/blob/master/docs/spec/blockchain/encoding.md)

PR replaces it with the updated link.

Details

File was move there: https://github.com/tendermint/tendermint/blob/main/spec/blockchain/encoding.md

which says it's been moved there:
https://github.com/tendermint/tendermint/blob/main/spec/core/encoding.md


For the future, since we have a version in the monorepo and gnolang/tendermint2, where is the best place to post PR?

Because gnolang/tendermint2 of course has the same issue (https://github.com/gnolang/tendermint2/blob/master/pkgs/amino/README.md)

@grepsuzette grepsuzette requested a review from a team as a code owner June 11, 2024 02:30
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (3f5a6ad) to head (6038701).
Report is 236 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2322      +/-   ##
==========================================
- Coverage   54.61%   54.60%   -0.02%     
==========================================
  Files         579      579              
  Lines       77899    77899              
==========================================
- Hits        42546    42535      -11     
- Misses      32182    32192      +10     
- Partials     3171     3172       +1     
Flag Coverage Δ
tm2 54.44% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@Kouteki Kouteki self-requested a review October 3, 2024 10:53
@Kouteki Kouteki removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@thehowl thehowl merged commit 4b3b419 into gnolang:master Oct 3, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants