Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default untyped to uint when necessary #2024

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented May 2, 2024

Closes #2004. This change allows for passing a value to defaultTypeOf. In the case where we are looking for the default value of an untyped int, it can use the value, if it exists, in order to determine whether the default type should be a signed or unsigned int.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 2, 2024
@deelawn deelawn marked this pull request as ready for review May 2, 2024 19:41
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (931f3d2) to head (7d58baa).

Files Patch % Lines
gnovm/pkg/gnolang/types.go 44.44% 3 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/preprocess.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
+ Coverage   54.61%   54.62%   +0.01%     
==========================================
  Files         581      581              
  Lines       77962    77966       +4     
==========================================
+ Hits        42579    42589      +10     
+ Misses      32205    32198       -7     
- Partials     3178     3179       +1     
Flag Coverage Δ
gnovm 60.03% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Pinging @petar-dambovaliev for a second look 🙏

@zivkovicmilos zivkovicmilos merged commit e7e47d2 into gnolang:master Jun 14, 2024
46 checks passed
jaekwon added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Overflow Occurs When Converting math.MaxUint64 to Floating-Point Types
4 participants