-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default untyped to uint when necessary #2024
fix: default untyped to uint when necessary #2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2024 +/- ##
==========================================
+ Coverage 54.61% 54.62% +0.01%
==========================================
Files 581 581
Lines 77962 77966 +4
==========================================
+ Hits 42579 42589 +10
+ Misses 32205 32198 -7
- Partials 3178 3179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Pinging @petar-dambovaliev for a second look 🙏
Closes #2004. This change allows for passing a value to
defaultTypeOf
. In the case where we are looking for the default value of an untyped int, it can use the value, if it exists, in order to determine whether the default type should be a signed or unsigned int.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description