-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txtar): add loadpkg
command
#1598
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
- Coverage 47.41% 44.56% -2.85%
==========================================
Files 385 460 +75
Lines 61319 67903 +6584
==========================================
+ Hits 29074 30264 +1190
- Misses 29826 35102 +5276
- Partials 2419 2537 +118 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than the few minor comments.
One more thing -- I noticed in the issue referenced here that it also says the premined addresses and balances should be removed, maybe with the exception of |
oh, yes you right! I will remove this in this PR, as it's not needed anymore with the |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
6a119c6
to
07025a7
Compare
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 👏
No specific comments, just a typo and an observation. Looks great 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few suggestions that might be worth taking a look. Rest LGTM 💯
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Great addition, but why calling it |
Do we keep at least one oldskool "Use" looks better, but since it's an integration test system, we need to explicitly keep at least one "using gnokey". |
So, @gfanton, from the review meeting:
thanks! |
Signed-off-by: gfanton <[email protected]>
@tbruyelle @moul @thehowl I think |
From the review meeting: agreed on |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
use
commandloadpkg
command
address #1484
This PR introduces the
loadpkg
command to gnoland integration using txtar:Additionally, this PR disables the default automatic loading of the example folder to keep test requirements minimal.
Moreover, it remove other
testX
users as specified in #1484 and retaining only the test1 user. Additional users can be added as needed using theadduser
command.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description