-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/moul/sourceless closure #1271
Draft
moul
wants to merge
23
commits into
gnolang:master
Choose a base branch
from
moul:dev/moul/sourceless-closure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
github-actions
bot
added
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
labels
Oct 21, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
- Coverage 47.84% 47.70% -0.14%
==========================================
Files 369 371 +2
Lines 62764 62812 +48
==========================================
- Hits 30028 29964 -64
- Misses 30308 30410 +102
- Partials 2428 2438 +10
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
maketx run
, a contract is "kinda" uploaded tor/g123456789/run
, executed, and then deleted. In practice, the contract itself is never stored, but any imported realm that undergoes changes is saved at the end of the transaction.The problem arises when we attempt to update another realm with a locally defined pointer or struct.
The GnoVM behaves differently when storing the typed value compared to the package path. The typed values belong to
PkgPath=r/g123455/run
, which cannot be lazily resolved in a subsequent transaction when someone attempts to call the imported package using that value (e.g., with a standardmaketx call
).There are several potential solutions to consider:
r/g1234567/runX
, to allow for later retrieval.r/g12344/run
without retaining the source code.run
contracts as if they werep/
, enforcing stateless.r/g123456/run
. This dummy package can remain empty, allowing lazy imports to proceed without failure.