Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: examples of upgrade patterns #125

Merged
merged 7 commits into from
Aug 20, 2022

Conversation

moul
Copy link
Member

@moul moul commented Apr 20, 2022

Plans for this PR:

  • test various upgrade patterns (3 in mind right now)
  • test how is the support of realms' subdir
  • extend r/tests and write more unit tests in tests/
  • initial p/upgrade package with helpers (Later)

@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch 2 times, most recently from 537da13 to 01a79b0 Compare April 20, 2022 17:29
@moul moul marked this pull request as draft April 20, 2022 17:29
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch 4 times, most recently from f4c2876 to d2cec9d Compare April 22, 2022 08:12
@anarcher
Copy link
Contributor

anarcher commented Apr 25, 2022

I have no experience with smart contracts, but in my short opinion, smart contract upgrades are similar to some kind of database migration. If the state of v1 and the state of v2 are used separately, even if there is a proxy contract, I think that upgrading becomes one of the difficult tasks. Like database migration, I think that the process of migrating the state of v1 to the state of v2 is necessary. (or delete v1?).

@moul moul force-pushed the dev/moul/upgrade-patterns branch from d2cec9d to 9e060fa Compare April 27, 2022 07:23
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch from 9e060fa to 3216edf Compare April 27, 2022 20:57
@moul moul added dapp 📖 documentation Improvements or additions to documentation labels May 9, 2022
@moul moul self-assigned this May 10, 2022
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch from 3216edf to 42de99b Compare May 21, 2022 22:17
@moul moul changed the title chore: examples of upgrade patterns WIP chore: examples of upgrade patterns May 30, 2022
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch from 42de99b to 4acef87 Compare May 30, 2022 22:16
@moul moul force-pushed the dev/moul/upgrade-patterns branch from 6327904 to b2f728c Compare July 5, 2022 09:20
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch from b2f728c to 36bd5f2 Compare August 20, 2022 14:57
@moul-bot moul-bot force-pushed the dev/moul/upgrade-patterns branch from 36bd5f2 to 80d5f51 Compare August 20, 2022 15:17
@moul moul marked this pull request as ready for review August 20, 2022 15:17
@moul moul merged commit 770b386 into gnolang:master Aug 20, 2022
@moul moul deleted the dev/moul/upgrade-patterns branch August 20, 2022 16:17
@moul moul added this to the 🏗1️⃣ test1.gno.land milestone Oct 20, 2022
@moul moul changed the title WIP chore: examples of upgrade patterns chore: examples of upgrade patterns Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants