fix(make): disable _test.gnoweb temporarily #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
thehowl
force-pushed
the
dev/morgan/disable-gnoweb
branch
2 times, most recently
from
ccc023f to
3a47e33
Compare
github-actions
bot
removed
the
🧾 package/realm
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
==========================================
- Coverage 47.86% 47.80% -0.06%
==========================================
Files 369 369
Lines 62710 62710
==========================================
- Hits 30018 29981 -37
- Misses 30271 30304 +33
- Partials 2421 2425 +4 ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Oct 11, 2023
|
Cc @gfanton, if you can quickly fix it, please close this PR. If you need more time for your in-memory PR, please merge this one first and then revert it in your PR. |
gfanton
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
@moul Im almost sure it will not be quick, even if Im able to finish it tomorrow it still need a review and a the PR will not be short.
So let merge this, I will try to open a draft PR ASAP with the in_memory node and a commit reverting this one
gfanton
added a commit
to gfanton/gno
that referenced
this pull request
Oct 11, 2023
This reverts commit dce345f. Signed-off-by: gfanton <[email protected]>
thehowl
added a commit
to thehowl/gno
that referenced
this pull request
Oct 21, 2023
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See-also: #1222
(h/t @jaekwon )