fix(codecov): increase codecov upload attempt #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to avoid `Unable to locate build via Github Actions API` by increasing codecov upload attempt based on this issue: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954 Signed-off-by: gfanton <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
==========================================
+ Coverage 47.00% 47.02% +0.02%
==========================================
Files 365 365
Lines 61156 61156
==========================================
+ Hits 28748 28761 +13
+ Misses 30052 30041 -11
+ Partials 2356 2354 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
moul
approved these changes
Oct 2, 2023
7 tasks
moul
pushed a commit
that referenced
this pull request
Oct 3, 2023
It appears that the retry system introduced in #1186 was not sufficient, as we still hit API limits when running multiple checks concurrently. This PR merges all coverage files into a single upload at the of each testing workflows. As a result, we now have 3 uploads instead of 16, which should drastically reduce the number of Codecov upload failures. Note: It still appears to fail randomly, but we might need to wait some time until our API rate decreases. I believe it's still preferable to have 3 uploads rather than 16, which seemed to overwhelm Codecov. --------- Signed-off-by: gfanton <[email protected]>
gfanton
added a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
multiple workflows were failing randomly with `Unable to locate build via Github Actions API` error like: - https://github.com/gnolang/gno/actions/runs/6349517658/job/17247838334?pr=1179 - https://github.com/gnolang/gno/actions/runs/6378366330/job/17308780300?pr=1117 - ... based on this [issue#3954](https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954) from `community.codecov.com` adding `codecov upload token` should resolve most issues. However, in some rare instances where API limits are still reached, a re-upload attempt should be made. This PR introduces a retry action to allow codecov to reattempt the upload if it fails the first time. --------- Signed-off-by: gfanton <[email protected]>
gfanton
added a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
…#1190) It appears that the retry system introduced in gnolang#1186 was not sufficient, as we still hit API limits when running multiple checks concurrently. This PR merges all coverage files into a single upload at the of each testing workflows. As a result, we now have 3 uploads instead of 16, which should drastically reduce the number of Codecov upload failures. Note: It still appears to fail randomly, but we might need to wait some time until our API rate decreases. I believe it's still preferable to have 3 uploads rather than 16, which seemed to overwhelm Codecov. --------- Signed-off-by: gfanton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple workflows were failing randomly with
Unable to locate build via Github Actions APIerror like:based on this issue#3954 from
community.codecov.comaddingcodecov upload tokenshould resolve most issues. However, in some rare instances where API limits are still reached, a re-upload attempt should be made.This PR introduces a retry action to allow codecov to reattempt the upload if it fails the first time.