Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: portal loop's main contracts and gnoweb improvements #1176

Merged
merged 23 commits into from
Oct 20, 2023

Conversation

moul
Copy link
Member

@moul moul commented Sep 27, 2023

Addresses #1131

Completed Tasks

  • Completed the home page by adding static content and blocks.
  • Implemented support for redirects and aliases to improve SEO.
  • Made some improvements to p/demo/ui, but more work is still needed.
  • Enhanced p/demo/blog by adding widget support.
  • Transferred previous static webpages to realms.
  • Created a new personal realm p/manfred/present for a Gno-powered presentation.
  • Refactored gnoweb to remove static pages, improve maintainability and design consistency, and added optional analytics.

Next Steps after Merging

  • Anyone:
    • Improve r/gnoland/home.
    • Create and enhance additional p/demo/* pages to simplify maintenance of r/gnoland/home.
    • Start writing personal and team realms to incorporate more dynamic data on-chain. Consider adding these realms as widgets on the homepage.
    • Encourage individuals to create dedicated realms, preferably dynamic ones. Then, import these new realms into the homepage to include widgets such as "upcoming events."
  • Manfred:
    • Develop dynamic contracts for Worxdao, including project, team, and people directories. Also, implement DAO features v0 and contributor profiles.

@moul moul self-assigned this Sep 27, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e8fbd3) 47.78% compared to head (eced226) 47.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   47.78%   47.89%   +0.10%     
==========================================
  Files         369      372       +3     
  Lines       62702    62915     +213     
==========================================
+ Hits        29963    30131     +168     
- Misses      30303    30343      +40     
- Partials     2436     2441       +5     

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: moul <[email protected]>
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Sep 27, 2023
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@moul moul changed the title dev/moul/home Home+WorxDAO PoC Oct 1, 2023
@moul moul changed the title Home+WorxDAO PoC Portal Loop: Home+WorxDAO PoC Oct 1, 2023
@moul moul mentioned this pull request Oct 1, 2023
9 tasks
@moul moul mentioned this pull request Oct 11, 2023
10 tasks
@moul moul changed the title Portal Loop: Home+WorxDAO PoC feat: Portal Loop: Home+WorxDAO PoC Oct 18, 2023
@moul moul changed the title feat: Portal Loop: Home+WorxDAO PoC feat: portal loop's main contracts and gnoweb improvements Oct 19, 2023
@moul moul marked this pull request as ready for review October 19, 2023 14:39
@moul moul requested a review from a team as a code owner October 19, 2023 14:39
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some links that are broken, but I don't think they are directly linked to this PR. Otherwise, LGTM


- [About](/about)
- [GitHub](https://github.com/gnolang)
- [Subscribe](#subscribe)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Subscribe](#subscribe)
- [Subscribe](#) (soon)

ui.Link{URL: "r/demo/microblog"},
ui.Link{URL: "r/demo/nft"},
ui.Link{URL: "r/demo/types"},
ui.Link{URL: "r/demo/art"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link

ui.H4("r/gnoland"),
ui.BulletList{
ui.Link{URL: "r/gnoland/blog"},
ui.Link{URL: "r/gnoland/dao"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link looks broken, should we keep it anyway ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's utilize the portal loop effect to have someone (perhaps you) open different PRs solely using gnoweb. They can fix issues while browsing.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Love the widget idea

gno.land/cmd/gnoweb/main.go Outdated Show resolved Hide resolved
@moul moul merged commit d29509e into gnolang:master Oct 20, 2023
182 checks passed
@moul moul deleted the dev/moul/home branch October 20, 2023 03:08
@moul moul mentioned this pull request Oct 20, 2023
moul added a commit that referenced this pull request Oct 20, 2023
Due to #1176 (removing `-pages-dir` flag from `gnoweb`)
Blocks #1108

Signed-off-by: moul <[email protected]>
thehowl pushed a commit to thehowl/gno that referenced this pull request Oct 21, 2023
)

Addresses gnolang#1131

## Completed Tasks

-  [x] Completed the home page by adding static content and blocks.
-  [x] Implemented support for redirects and aliases to improve SEO.
- [x] Made some improvements to p/demo/ui, but more work is still
needed.
-  [x] Enhanced p/demo/blog by adding widget support.
-  [x] Transferred previous static webpages to realms.
- [x] Created a new personal realm `p/manfred/present` for a Gno-powered
presentation.
- [x] Refactored gnoweb to remove static pages, improve maintainability
and design consistency, and added optional analytics.

## Next Steps after Merging

- Anyone:
  - Improve r/gnoland/home.
- Create and enhance additional `p/demo/*` pages to simplify maintenance
of `r/gnoland/home`.
- Start writing personal and team realms to incorporate more dynamic
data on-chain. Consider adding these realms as widgets on the homepage.
- Encourage individuals to create dedicated realms, preferably dynamic
ones. Then, import these new realms into the homepage to include widgets
such as "upcoming events."
- Manfred:
- Develop dynamic contracts for Worxdao, including project, team, and
people directories. Also, implement DAO features v0 and contributor
profiles.

---------

Signed-off-by: moul <[email protected]>
thehowl pushed a commit to thehowl/gno that referenced this pull request Oct 21, 2023
Due to gnolang#1176 (removing `-pages-dir` flag from `gnoweb`)
Blocks gnolang#1108

Signed-off-by: moul <[email protected]>
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
)

Addresses gnolang#1131

## Completed Tasks

-  [x] Completed the home page by adding static content and blocks.
-  [x] Implemented support for redirects and aliases to improve SEO.
- [x] Made some improvements to p/demo/ui, but more work is still
needed.
-  [x] Enhanced p/demo/blog by adding widget support.
-  [x] Transferred previous static webpages to realms.
- [x] Created a new personal realm `p/manfred/present` for a Gno-powered
presentation.
- [x] Refactored gnoweb to remove static pages, improve maintainability
and design consistency, and added optional analytics.

## Next Steps after Merging

- Anyone:
  - Improve r/gnoland/home.
- Create and enhance additional `p/demo/*` pages to simplify maintenance
of `r/gnoland/home`.
- Start writing personal and team realms to incorporate more dynamic
data on-chain. Consider adding these realms as widgets on the homepage.
- Encourage individuals to create dedicated realms, preferably dynamic
ones. Then, import these new realms into the homepage to include widgets
such as "upcoming events."
- Manfred:
- Develop dynamic contracts for Worxdao, including project, team, and
people directories. Also, implement DAO features v0 and contributor
profiles.

---------

Signed-off-by: moul <[email protected]>
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
Due to gnolang#1176 (removing `-pages-dir` flag from `gnoweb`)
Blocks gnolang#1108

Signed-off-by: moul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: ✅ Done
Status: 🚀 Needed for Launch
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants