-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlibs): add math and math/bits #1153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 55.94% 48.26% -7.68%
==========================================
Files 420 377 -43
Lines 65477 64130 -1347
==========================================
- Hits 36631 30955 -5676
- Misses 25983 30731 +4748
+ Partials 2863 2444 -419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Draft until #1221 |
I've now cleaned up the code in the PR, since we merged #1221 :) Reviews welcome! |
Can this block be removed as part of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. As noted in my other comment, I think it would be slightly more correct to include the following files inside _test
suffixed packages:
- all_test.gno
- bits_test.gno
- const_test.gno
I'm also happy to take care of these changes; just let me know.
@deelawn just took care of the changes you requested. export_test.go needs to be in If this looks good I think we can probably merge later today. :) |
Co-authored-by: Antonio Navarro Perez <[email protected]>
Great bug-finder package:
This adds packages
math
andmath/bits
, copied from go standard libraries with minimal modifications.The changes from the standard libraries can be inspected with the following scripts:
These will generate a diff for each file in /usr/lib/src/go, and their gno counterpart in each directory.
Most changes involve removing the
if haveXXXArch
statements in the many functions which normally support being executed as native assembly instructions.Additionally, within tests, all the dot imports present were removed (as they are not supported in Gno), and some bugs had to be worked around (I added references wherever this was the case).
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description