Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix codecov #1146

Merged
merged 1 commit into from
Sep 18, 2023
Merged

chore: Fix codecov #1146

merged 1 commit into from
Sep 18, 2023

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Sep 18, 2023

Split coverages by component.

Check if it works better than prev iteration after doing some research: https://docs.codecov.com/docs/carryforward-flags

Signed-off-by: Antonio Navarro Perez [email protected]

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: Antonio Navarro Perez <[email protected]>
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (07ff4ab) 47.06% compared to head (33fe711) 47.06%.

❗ Current head 33fe711 differs from pull request most recent head 2bf549f. Consider uploading reports for the commit 2bf549f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   47.06%   47.06%           
=======================================
  Files         364      364           
  Lines       61148    61149    +1     
=======================================
+ Hits        28779    28780    +1     
+ Misses      30019    30016    -3     
- Partials     2350     2353    +3     
Flag Coverage Δ
gno.land-_test.gnokey ∅ <ø> (?)
gno.land-_test.gnoland 88.14% <ø> (ø)
gno.land-_test.pkgs 27.88% <ø> (ø)
gnovm-_test.cmd 45.89% <ø> (ø)
gnovm-_test.gnolang.native 63.09% <ø> (ø)
gnovm-_test.gnolang.other 16.63% <ø> (ø)
gnovm-_test.gnolang.pkg0 17.98% <ø> (ø)
gnovm-_test.gnolang.pkg1 8.21% <ø> (ø)
gnovm-_test.gnolang.pkg2 9.87% <ø> (ø)
gnovm-_test.gnolang.realm 41.68% <ø> (ø)
gnovm-_test.gnolang.stdlibs 53.53% <ø> (ø)
gnovm-_test.pkg 25.96% <ø> (ø)
tm2-_test.pkg.amino 58.32% <100.00%> (+<0.01%) ⬆️
tm2-_test.pkg.bft 63.80% <ø> (ø)
tm2-_test.pkg.others 59.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tm2/pkg/amino/amino.go 42.53% <100.00%> (+0.09%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Sep 18, 2023
@ajnavarro ajnavarro marked this pull request as ready for review September 18, 2023 14:39
@ajnavarro ajnavarro requested a review from a team as a code owner September 18, 2023 14:39
@github-actions github-actions bot removed the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Sep 18, 2023
@moul moul merged commit b7bf42a into gnolang:master Sep 18, 2023
7 of 20 checks passed
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants