fix(vm): Release VM properly #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for gno-docs failed.
|
❌ Deploy Preview for gno-docs failed.
|
zivkovicmilos
approved these changes
Sep 13, 2023
thehowl
reviewed
Sep 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
- Coverage 46.98% 46.98% -0.01%
==========================================
Files 365 365
Lines 61159 61154 -5
==========================================
- Hits 28737 28734 -3
+ Misses 30062 30061 -1
+ Partials 2360 2359 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Properly clean slices using make (the internal logic is expecting slices to not be nil). It closes gnolang#1033 Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
fix/release-vm-properly
branch
from
0b09e9b to
3fa88d0
Compare
|
@thehowl Applied requested changes and added benchmarks: |
moul
approved these changes
Sep 22, 2023
thehowl
approved these changes
Sep 22, 2023
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
Properly clean slices using make (the internal logic is expecting slices to not be nil). It closes gnolang#1033 - [X] Added new tests, or not needed, or not feasible - [X] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [X] Updated the official documentation or not needed - [X] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [X] Added references to related issues and PRs - [X] Provided any useful hints for running manual tests - [X] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). --------- Signed-off-by: Antonio Navarro Perez <[email protected]> Co-authored-by: Manfred Touron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly clean slices using make (the internal logic is expecting slices to not be nil).
It closes #1033
BREAKING CHANGE: xxxmessage was included in the description