-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Effective Gno #1000
docs: Effective Gno #1000
Conversation
0a9fac1
to
d96c266
Compare
77c66c0
to
cb8df8f
Compare
cb8df8f
to
e49b255
Compare
Signed-off-by: Manfred Touron <[email protected]>
e49b255
to
a9359c0
Compare
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]> Co-authored-by: Morgan <[email protected]>
Co-authored-by: Morgan <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide looks good to me and is extremely useful.
To go further, it would be also useful to have pointers on grc20 or grc721 reference documents, and other important concept documents about smart contracts, if they exist. The same for relevant security practices. I'm always found of a solid bibliography which enhances the quality a lot.
Co-authored-by: Marc Vertes <[email protected]>
Pending @leohhhn review, if all's good we can merge afterwards! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a couple of suggestions, mostly related to token <> coin consistency, and typos. Looks awesome, can't wait to merge this 💯
Co-authored-by: Leon Hudak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked banker locally, take a look at suggestion :)
Co-authored-by: Leon Hudak <[email protected]>
MERGING! |
I'm working towards a concise style, suggesting an initial review of [Effective Go](https://go.dev/doc/effective_go), followed by Gno-specific practices. I'm also considering making code snippets in this documentation unit-testable. --------- Signed-off-by: Manfred Touron <[email protected]> Signed-off-by: moul <[email protected]> Co-authored-by: jon roethke <[email protected]> Co-authored-by: Leon Hudak <[email protected]> Co-authored-by: Morgan <[email protected]> Co-authored-by: Marc Vertes <[email protected]>
I'm working towards a concise style, suggesting an initial review of Effective Go, followed by Gno-specific practices. I'm also considering making code snippets in this documentation unit-testable.