Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gnoweb] Clicking the gno.mod source on realms returns 404 #2277

Closed
RezaRahemtola opened this issue Jun 4, 2024 · 0 comments · Fixed by #2278
Closed

[gnoweb] Clicking the gno.mod source on realms returns 404 #2277

RezaRahemtola opened this issue Jun 4, 2024 · 0 comments · Fixed by #2278

Comments

@RezaRahemtola
Copy link
Member

gno.mod

Description

When browsing a realm on gno.land, when clicking on the gno.mod file of the sources, it returns a 404 error.

Example with https://gno.land/r/gnoland/blog/gno.mod
image

This only occurs for realms and not packages.

Your environment

Both locally with gnodev and in https://gno.land

Steps to reproduce

  • Go to any realm sources page on gnoweb
  • Click the gno.mod file
  • It shows a 404 error

Expected behaviour

It should display the content of the file

Actual behaviour

It returns a 404 error

Proposed solution

Fix incoming in a PR
This was referenced Jun 4, 2024
Merged
Open
deelawn pushed a commit that referenced this issue Jun 6, 2024
@RezaRahemtola
fix: Handle .mod files for realms in gnoweb (#2278)
fabf6c8 
Fixes #2277 to render `.mod` files for realms

Before:

![image](https://github.com/gnolang/gno/assets/49811529/6ef8e4a0-76b7-4a2c-9720-9158e9d67d08)

After:

![image](https://github.com/gnolang/gno/assets/49811529/20d0876d-eee6-4c3b-a74f-22c0314f074e)



<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle .mod files for realms in gnoweb RezaRahemtola/gno
1 participant
@RezaRahemtola