Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install build fails on non-wsl Windows 11 environment #1060

Closed
eugen-kleiner-mesh opened this issue Aug 20, 2023 · 3 comments · Fixed by #1089
Closed

make install build fails on non-wsl Windows 11 environment #1060

eugen-kleiner-mesh opened this issue Aug 20, 2023 · 3 comments · Fixed by #1089

Comments

@eugen-kleiner-mesh
Copy link

eugen-kleiner-mesh commented Aug 20, 2023

make install fails on make install fails on non-wsl Windows 11 environment

Description

When trying to run make install on Windows 11 using non-wsl environment (cmd, Git bash) - build it fails with the next error:
..\tm2\pkg\commands\utils.go:44:38: cannot use fd (variable of type syscall.Handle) as int value in argument to term.ReadPassword

Might not need resolution since Non-WSL environment is not recommended (means, not supported?) according to README.md

Your environment

  • Windows 11 Pro 22621.2134
  • master branch b40ac9c

Steps to reproduce

  • Go to gno dir
  • Run make install
  • Observe an error:
$ make install
C:/ProgramData/chocolatey/lib/make/tools/install/bin/make.exe --no-print-directory -C ./gno.land        install.gnokey
go install ./cmd/gnokey
# github.com/gnolang/gno/tm2/pkg/commands
..\tm2\pkg\commands\utils.go:44:38: cannot use fd (variable of type syscall.Handle) as int value in argument to term.ReadPassword
make[1]: *** [Makefile:22: install.gnokey] Error 1
make: *** [Makefile:13: install_gnokey] Error 2
@eugen-kleiner-mesh
Copy link
Author

eugen-kleiner-mesh commented Aug 20, 2023

@eugen-kleiner-mesh eugen-kleiner-mesh changed the title make install fails on non-wsl Windows 11 environment make install build fails on non-wsl Windows 11 environment Aug 20, 2023
@moul
Copy link
Member

moul commented Aug 30, 2023

Thank you for your feedback.

We are currently refactoring the client component of tm2 to streamline the process of creating SDKs in Go. Once completed, this will significantly reduce the size of the CLI package, making it simpler to enhance Windows support.

Please note: While Windows support isn't our top priority at this time, we recognize its importance, especially for gnokey. If you or someone you know can enhance Windows support without compromising code clarity, we welcome a PR. In the meantime, we recommend using a Linux-based host (VM/server/OS).

Related with #1047

@thehowl
Copy link
Member

thehowl commented Aug 30, 2023

Seem to be related to issue ...

Slightly - that might be a problem when using gnokey at runtime; this is a compilation error.

I followed the issue you linked and adapted the code there for the fix; tell me if #1089 fixes the issue for you. Cheers!

moul pushed a commit that referenced this issue Aug 31, 2023
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants